t3c parentdotconfig: ensure ocgmap is ordered by prim, sec #7411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
traeak
force-pushed
the
fix_nontopo_mso_parent
branch
from
3b8f9f5
to
e89ccba
Compare
Codecov Report
@@ Coverage Diff @@
## master #7411 +/- ##
============================================
+ Coverage 27.03% 27.04% +0.01%
Complexity 98 98
============================================
Files 685 685
Lines 77279 77301 +22
Branches 90 90
============================================
+ Hits 20892 20909 +17
- Misses 54399 54404 +5
Partials 1988 1988
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
traeak
force-pushed
the
fix_nontopo_mso_parent
branch
2 times, most recently
from
9c7ed6c
to
2ddfcb8
Compare
ocket8888
added
bug
jpappa200
reviewed
Mar 21, 2023
ocket8888
reviewed
Mar 21, 2023
traeak
force-pushed
the
fix_nontopo_mso_parent
branch
from
a842090
to
20e1cae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bug in t3c was found when a topology for a MID is simulated for a non topology MSO delivery service with 2 origins in the primary and secondary groups and round_robin=false. The primary and secondary origin parent cache groups assignments weren't properly being transferred over to the created topology resulting in inconsistent origin ordering in parent.config
This bug fixes that by explicitly assigning primary and secondary parent cache groups to the intermediate struct.
Which Traffic Control components are affected by this PR?
t3c, formerly ORT)What is the best way to verify this PR?
Tested by creating a DS with:
Run t3c multiple times and ensure the parent.config is consistently created.
If this is a bugfix, which Traffic Control versions contained the bug?
PR submission checklist
This PR has documentation-- bug fix